[Bug 572512] Review Request: gluegen - Java/JNI glue code generator to call out to ANSI C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=572512

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-04-02 11:53:14 EDT ---
(In reply to comment #6)
> [lonely at localhost SPECS]$ rpmlint ../RPMS/noarch/gluegen-*
> gluegen-source.noarch: W: no-documentation
> -> Im building, now, a package named gluegen-manual. Maybe I should "requires"
> it also in the source package?
> gluegen-source.noarch: E: world-writable /usr/share/gluegen-source/gluegen 0777
> gluegen-source.noarch: E: non-standard-dir-perm
> /usr/share/gluegen-source/gluegen 0777
> -> About this two, unfortunately, the directory must be writable because, when
> building, jogl needs to create some files on if.

 
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENTDATA
  "The /usr/share hierarchy is for all *read-only* architecture independent
data files."
  - Writing files under /usr/share when building jogl is not allowed.

> 
> [lonely at localhost SPECS]$ rpmlint ../RPMS/i686/gluegen-*
> gluegen-debuginfo.i686: E: debuginfo-without-sources
> -> Was looking around and found some cases like this:
> https://bugzilla.redhat.com/show_bug.cgi?id=563001 that suggests that this
> error can be ignored.

- The review comment on that bug is about debuginfo issue is just wrong.
  Debuginfo rpm must be created correctly (if it is to be created).
  * I guess the reviewer on bug 563001 did not have redhat-rpm-config
    installed. In fact xfce4-remmina-plugin creates debuginfo rpm
    correctly:
    http://koji.fedoraproject.org/koji/buildinfo?buildID=162053

    One problem on this package is that build.log shows just
-----------------------------------------------------------------
   716  c.build:
   717       [echo] Output lib name = gluegen-rt
   718      [mkdir] Created dir: /builddir/build/BUILD/gluegen/build/obj
   719       [echo] Compiling src/native/unix/*.c
   720       [echo] user.dir=/builddir/build/BUILD/gluegen/make
   721         [cc] 1 total files to be compiled.
   722         [cc] cc1: warning: command line option "-fno-rtti" is valid for
C++/ObjC++ but not for C
   723         [cc] Starting link
-----------------------------------------------------------------
    and we cannot guess what command line is used here, especially
    what compilation flags are used (and so we cannot check if
    Fedora specific compilation flags are actually used:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags )

    To create debuginfo rpm correctly, at least
    - "-g" option is correctly passed to gcc (or so)
    - and build process must not strip the rebuilt binary by itself
    https://fedoraproject.org/wiki/Packaging:Debuginfo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.