[Bug 579063] Review Request: perl-Perl-Version - Parse and manipulate Perl version strings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579063

--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu> 2010-04-02 12:03:38 EDT ---
Looks good!

There's an examples/ directory; why not include it under %doc?

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2091102

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
9a1dd0d1eb4652ea7233c0d02df2bce84b470d2c Perl-Version-1.009.tar.gz
9a1dd0d1eb4652ea7233c0d02df2bce84b470d2c Perl-Version-1.009.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Perl-Version-1.009-1.fc14.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Perl-Version-1.009-1.fc14.noarch.rpm
perl(Perl::Version) = 1.009
perl-Perl-Version = 1.009-1.fc14
====> requires for perl-Perl-Version-1.009-1.fc14.noarch.rpm
perl(Carp)  
perl(constant)  
perl(:MODULE_COMPAT_5.10.1)  
perl(overload)  
perl(Scalar::Util)  
perl(strict)  
perl(warnings)  

=====> perl-Perl-Version-1.009-1.fc14.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Perl-Version-1.009-1.fc14.src.rpm
====> requires for perl-Perl-Version-1.009-1.fc14.src.rpm
perl(ExtUtils::MakeMaker)  
perl(File::Slurp) >= 9999.12
perl(Test::More)  
perl(Test::Pod)  
perl(Test::Pod::Coverage)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.