[Bug 579259] Review Request: perl-UNIVERSAL-ref - Turns ref() into a multimethod

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579259

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-04-04 05:04:17 EDT ---
+ source files match upstream.  
  2fb38adfb9415721496eeb8b552cc905  UNIVERSAL-ref-0.12.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2093234

+ package installs properly.
+ rpmlint has no serious complaints:
  perl-UNIVERSAL-ref.src: I: checking
  perl-UNIVERSAL-ref.src: W: spelling-error Summary(en_US) multimethod ->
multimedia, multifaceted, multicolored
  perl-UNIVERSAL-ref.src: W: spelling-error %description -l en_US builtin ->
built in, built-in, built
  perl-UNIVERSAL-ref.src: I: checking-url
http://search.cpan.org/dist/UNIVERSAL-ref (timeout 10 seconds)
  perl-UNIVERSAL-ref.src: I: checking-url
http://search.cpan.org/CPAN/authors/id/J/JJ/JJORE/UNIVERSAL-ref-0.12.tar.gz
(timeout 10 seconds)
  perl-UNIVERSAL-ref.x86_64: I: checking
  perl-UNIVERSAL-ref.x86_64: W: spelling-error Summary(en_US) multimethod ->
multimedia, multifaceted, multicolored
  perl-UNIVERSAL-ref.x86_64: W: spelling-error %description -l en_US builtin ->
built in, built-in, built
  perl-UNIVERSAL-ref.x86_64: I: checking-url
http://search.cpan.org/dist/UNIVERSAL-ref (timeout 10 seconds)
  perl-UNIVERSAL-ref-debuginfo.x86_64: I: checking
  perl-UNIVERSAL-ref-debuginfo.x86_64: I: checking-url
http://search.cpan.org/dist/UNIVERSAL-ref (timeout 10 seconds)
  perl-UNIVERSAL-ref-tests.x86_64: I: checking
  perl-UNIVERSAL-ref-tests.x86_64: I: checking-url
http://search.cpan.org/dist/UNIVERSAL-ref (timeout 10 seconds)
  perl-UNIVERSAL-ref-tests.x86_64: W: no-documentation
  4 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ final provides and requires are sane:
  perl(UNIVERSAL::ref) = 0.12
  perl-UNIVERSAL-ref = 0.12-1.fc13
  perl-UNIVERSAL-ref(x86-64) = 0.12-1.fc13
=
  libc.so.6()(64bit)  
  libc.so.6(GLIBC_2.2.5)(64bit)  
  perl(B)  
  perl(B::Utils)  
  perl(B::Utils)  
  perl(:MODULE_COMPAT_5.10.1)  
  perl(strict)  
  perl(warnings)  
  perl(XSLoader)  
+ %check is present and all tests pass.
  t/basic.t .. ok
  All tests successful.
  Files=1, Tests=11,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.05 cusr  0.01
csys =  0.08 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.