[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent

bugzilla at redhat.com bugzilla at redhat.com
Sun Apr 4 19:08:49 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579171

--- Comment #2 from Kevin Fenzi <kevin at tummy.com> 2010-04-04 15:08:45 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
See below - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. Your git checkout comment has the wrong repo in it. ;) 

Should be  git://lxde.git.sourceforge.net/gitroot/lxde/lxpolkit

2. rpmlint says: 

lxpolkit.src:27: W: unversioned-explicit-provides
PolicyKit-authentication-agent

Should that be versioned? I would guess not.

lxpolkit.src: W: invalid-url Source0: lxpolkit-20100402git5087383.tar.bz2
lxpolkit.x86_64: W: conffile-without-noreplace-flag
/etc/xdg/autostart/lxpolkit.desktop

Should this be config(noreplace)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list