[Bug 569099] Review Request: rubygem-parseconfig - Ruby Configuration File Parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569099

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-04-04 15:21:15 EDT ---
Some initial comments:

* %define -> %global
  - Now we prefer to use %global instead of %define:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

* Unused macros
  - %ruby_sitelib, %installroot seem to be used nowhere.

* About URL
  - Well, usually rubygems can be found at
    http://rubygems.org/gems/%{gemname}-%{version}.gem
    ( Previously: http://gems.rubyforge.org/gems/%{gemname}-%{version}.org
      Now it seems that gems.rubyforge.org is redirected to
      http://rubygems.org )
    and we usually suggest to use this URL, however currently only
    version 0.5 of parseconfig gem is found from this site.

    As you seem to be the upstream of this software, perhaps you can
    request to make 0.5.2 gem hosted on rubygems.org.

* ruby(abi) dependency
  - Please add (note that at least EL-5 ruby-libs has Provides: ruby(abi),
    although EL-4 ruby-libs does not)

* %check
  - is currently not needed for this package (just changing working
    directory is not needed)

* build failure
  - Build fails at least on F-13:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2094635

    ! Note
      rubygems >= 1.3.3 will automatically generate ri manuals by default.

* Directory ownership issue
  - At least the following directories themselves are not owned 
    by any packages:
-----------------------------------------------------------------------
%{geminstdir}/
%{geminstdir}/lib/
-----------------------------------------------------------------------
   
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
   
https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Forgetting_to_Include_a_Toplevel_Directory

* Permission on parseconfig.rb
  - %{geminstdir}/lib/parseconfig.rb need not have executable permission,
    and need not have shebang.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.