[Bug 578994] Review Request: abinit - Full-featured atomic-scale first-principles simulation software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578994

--- Comment #5 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-04-05 15:50:55 EDT ---
Oh, and a few other things:

- Get rid of commented lines that are empty.

- Please don't use macros for standard commands. Even though rpm has macros
such as %__mv, %__cp, %__make and so on, IMHO they just make the spec file
harder to read.

- Don't use %makeinstall, it's forbidden in the packaging guidelines. Use
 make install DESTDIR=%{buildroot}
or
  make install DESTDIR=$RPM_BUILD_ROOT
instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.