[Bug 578994] Review Request: abinit - Full-featured atomic-scale first-principles simulation software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578994

--- Comment #4 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-04-05 15:48:16 EDT ---
The first issues that come to mind:

- Explicit requires are banned by Packaging Guidelines

- BuildRequires are missing. Need at least:

BuildRequires: gcc-gfortran
BuildRequires: lapack-devel

- There are some other programs and libraries that are supported by abinit and
are already in Fedora (for instance wannier90). Relevant buildrequires need to
be added and the configure switches turned on.

- Some thought could be put in packaging the supported addons that aren't yet
in Fedora (for instance bigdft).

- This program supports MPI, so the MPI versions should also be packaged (MPI
guidelines). This part can be a bit rough, at least it is very likely to make
the spec file very hard to read.

**

What is your interest in packaging abinit? Do you use it yourself?

Have you made any other submission yet?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.