[Bug 470547] Review Request: emacs-semi - MIME rendering library for Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470547

--- Comment #14 from Jonathan Underwood <jonathan.underwood at gmail.com> 2010-04-05 20:29:14 EDT ---
Also, the spec file needs updating to comply with the latest Emacs add-on
packaging guidelines. http://fedoraproject.org/wiki/Packaging:Emacs

Specifically, these changes need to be made to the spec file. 

1/ the pkgconfig stuff can be removed

2/the emacs specific macros need to be changed accordingly eg %{emacs_version}
should now be %{_emacs_version} etc

3/ No need to buildrequire emacs-el

4/ Comments need adding to the spec file about the patches - have these been
sent upstream? If so, supply a date, an email archive url or a bugzilla url.

5/ BuildRoot is no longer needed - remove.

6/ In install, remove the rm -rf $RPM_BUILD_ROOT

7/ Fix up the changelog entry to properly comply with the guidelines

Once these are done I'll finish the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.