[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 6 01:42:10 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501101

--- Comment #9 from Jonathan Underwood <jonathan.underwood at gmail.com> 2010-04-05 21:42:05 EDT ---
The package needs updating to comply with the most recent emacs packaging
guidelines: http://fedoraproject.org/wiki/Packaging:Emacs

Specifically, in the spec file:

1/ Remove the pkgconfig stuff

2/ Update the macros to use the new names eg %{emacs_version}->{_emacs_version}
etc

3/ Don't buildrequire emacs-el

4/ Add comments about the patches - have they been sent upstream, if so when.
Give URLs to upstream bugzilla or mailing list archives if appropriate

5/ Spec file legibility is compromised by having lines commented out,
particularly ones which begin with macros - commenting a macro may not always
disable it! Please remove the unneeded commented code lines from the spec file.

In addition, note that color-theme is already included in the emacs-goodies
package which is already in Fedora. Personally I would like to see color-theme
packaged separately from the goodies collection (which contains a lot of nasty
elsip of low quality). Once this passes review you'll need to coordinate with
the emacs-goodies package owner to remove the color theme stuff from that
package.


Formal Review:
Key: 
[X] All is OK.
[A] Needs action


[A] MUST: rpmlint must be run on every package. The output should be posted in
the review.

--->See comment #8 for things that need fixing.

[X] MUST: The package must be named according to the Package Naming Guidelines
.
[X] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
[A] MUST: The package must meet the Packaging Guidelines .
---> See the points above
[X] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[A] MUST: The License field in the package spec file must match the actual
license.
--->color-theme.el states that the files is GPLv2+, but the spec file says
GPLv2. This needs clarifying.
[X]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
[X] MUST: The spec file must be written in American English. [5]
[A] MUST: The spec file for the package MUST be legible. [6]
---> See point above about removing the commented out lines

[X] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
Packaged source md5sum:  
     a4de73c236a6af11ab378bfe18dabcca  color-theme-6.6.0.tar.gz
Upstream md5sum:
     a4de73c236a6af11ab378bfe18dabcca  color-theme-6.6.0.tar.gz
[X] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture. [7]
[X] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
[X] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[X] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[X] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
[X] MUST: Packages must NOT bundle copies of system libraries.[11]
[X] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12]
[X] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
[X] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. [14]
[X] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. [15]

[A] MUST: Each package must consistently use macros. [16]
----> Please use the correct macros from the most recent Emacs add-on packaging
guidelines

[X] MUST: The package must contain code, or permissable content. [17]
[X] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). [18]
[X] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present. [18]
[X] MUST: Header files must be in a -devel package. [19]
[X] MUST: Static libraries must be in a -static package. [20]
[X] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. [19]
[X] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} [21]
[X] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[20]
[X] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[22]
[X] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. [23]
[X] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT). [24]
[X] MUST: All filenames in rpm packages must be valid UTF-8. [25]



[X] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[26]
[X] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[27]
[X] SHOULD: The reviewer should test that the package builds in mock. [28]
[X] SHOULD: The package should compile and build into binary rpms on all
supported architectures. [29]
[X] SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
[X] SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity. [30]
[X] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency. [21]
[X] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb. [31]
[X] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. [32]
[X] SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.[33]

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list