[Bug 579327] Review Request: perl-Perl-PrereqScanner - Tool to scan your Perl code for its prerequisites

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579327

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-04-06 00:22:16 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2093995
+ rpmlint is silent for SRPM and for RPM.
perl-Perl-PrereqScanner.noarch: I: checking-url
http://search.cpan.org/dist/Perl-PrereqScanner/ (timeout 10 seconds)
perl-Perl-PrereqScanner.src: I: checking-url
http://search.cpan.org/dist/Perl-PrereqScanner/ (timeout 10 seconds)
perl-Perl-PrereqScanner.src: I: checking-url
http://www.cpan.org/authors/id/J/JQ/JQUELIN/Perl-PrereqScanner-0.100830.tar.gz
(timeout 10 seconds)
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ source files match upstream url (sha1sum)
aef5256d1e54b2ccbeef1e40ce635616fc5b1fe5  Perl-PrereqScanner-0.100830.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=72,  0 wallclock secs ( 0.02 usr  0.02 sys +  0.43 cusr  0.06
csys =  0.53 CPU)
+ Package perl-Perl-PrereqScanner-0.100830-1.fc14.noarch =>
Provides: perl(Perl::PrereqScanner) = 0.100830
Requires: perl >= 0:5.008 perl(File::Spec::Functions) perl(FindBin) perl(lib)
perl(List::Util) perl(namespace::autoclean) perl(Perl::PrereqScanner) perl(PPI)
>= 1.205 perl(Scalar::Util) perl(strict) perl(Version::Requirements) >=
0.100630 perl(warnings) rpmlib(VersionedDependencies) <= 3.0.3-1 /usr/bin/perl

+ Not a GUI application

Suggestions:
1) Remove following from SPEC
BuildRequires:  perl >= 0:5.008

2) Also, I think following can be removed
BuildRequires:  perl(PPI::Document)
as following is already included 
BuildRequires:  perl(PPI) >= 1.205

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.