[Bug 579322] Review Request: perl-Log-Dispatchouli - Simple wrapper around Log::Dispatch

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579322

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-04-06 00:27:12 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2093965
+ rpmlint is silent for SRPM and for RPM.
perl-Log-Dispatchouli.noarch: I: checking-url
http://search.cpan.org/dist/Log-Dispatchouli/ (timeout 10 seconds)
perl-Log-Dispatchouli.src: I: checking-url
http://search.cpan.org/dist/Log-Dispatchouli/ (timeout 10 seconds)
perl-Log-Dispatchouli.src: I: checking-url
http://www.cpan.org/authors/id/R/RJ/RJBS/Log-Dispatchouli-1.100712.tar.gz
(timeout 10 seconds)
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ source files match upstream url (sha1sum)
f634b060963f7b3551cb98a4cba9a104c65c4405  Log-Dispatchouli-1.100712.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=33,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.23 cusr  0.02
csys =  0.28 CPU)

+ Package perl-Log-Dispatchouli-1.100712-1.fc14.noarch =>
Provides: perl(Log::Dispatchouli) = 1.100712 perl(Log::Dispatchouli::Proxy) =
1.100712
Requires: perl(Carp) perl(Log::Dispatch) perl(Params::Util) perl(Scalar::Util)
perl(strict) perl(String::Flogger) perl(Try::Tiny) >= 0.04 perl(warnings)
rpmlib(VersionedDependencies) <= 3.0.3-1

+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.