[Bug 578024] Review Request: ingres - Relational DBMS Server and Utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578024

Matthias Runge <mrunge at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrunge at fedoraproject.org

--- Comment #2 from Matthias Runge <mrunge at fedoraproject.org> 2010-04-07 05:30:20 EDT ---
Well,

since it's a large beast, I would really appreciate help for a review.

Ingres builds fine under F-12 and mock

rpmlint ingres.spec
ingres.spec: W: invalid-url Source0: ingres-10.0.0-20100329svn2734.tgz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.


rpmlint over compiled binaries produces:
5 packages and 0 specfiles checked; 102 errors, 600 warnings.

Warnings are mostly non-standard-gid/uid

More interesting
ingres-client.i686: E: non-standard-dir-perm /var/lib/ingres/files/name 0700
ingres-client.i686: E: setuid-binary /usr/libexec/ingres/bin/ingvalidpam root
04
511
ingres-client.i686: E: non-standard-executable-perm
/usr/libexec/ingres/bin/ingv
alidpam 04511
ingres-client.i686: E: non-standard-executable-perm
/usr/libexec/ingres/bin/ingv
alidpam 04511

* logrotate script is missing

* why do you start ingres-server in ingres-client package? IMHO, that's not
necessary.

* ingres-server.i686: W: non-conffile-in-etc /etc/ld.so.conf.d/ingres-i386.conf

I would mark it as conf-file and remove arch from file-name
%config /etc/ld.so.conf.d/ingres.conf
same for pam-message in ingres-client

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.