[Bug 549223] Review Request: ignuit - A memorization aiding tool

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 7 18:38:53 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549223

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2010-04-07 14:38:48 EDT ---
Hi Fabian,
here are a couple of initial comments:

- GConf schemas files must be handled properly, see:
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf

- According to COPYING.extras, the PNG images are licensed under GPLv2.
  This must me reflected in the License field
  Since GPLv2 is not compatible with GPLv3+, I'm not sure if upstream is
allowed 
  to license the whole package under GPLv3+

- in the %files section, replace omf/ignuit with omf/%{name}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list