[Bug 580169] Review Request: loggerhead - Web viewer for the Bazaar version control system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580169

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no

--- Comment #1 from Terje Røsten <terjeros at phys.ntnu.no> 2010-04-07 14:58:10 EDT ---
README.mod_wsgi seems wrong, there are no /etc/bazaar.conf in the package.

In loggerhead.conf, is it right to comment out this line

#Alias /bzr/static /usr/share/loggerhead/static

Is this line correct:

 WSGIScriptAlias /bzr /var/www/cgi-bin/loggerhead.wsgi


About the spec file:

 cp -p %{SOURCE4} %{buildroot}/%{_bindir}/

use install command here and drop %attr in %files.

mkdir -p %{buildroot}/%{_sysconfdir}/loggerhead/
cp -p %{SOURCE3} %{buildroot}/%{_sysconfdir}/loggerhead/

more simple and robust:

install -D -m 0644 -p %{SOURCE3}
%{buildroot}/%{_sysconfdir}/loggerhead/bazaar.conf


%attr(0755,root,root) %{_bindir}/*
%{_mandir}/man1/*

Explicit please.

%{python_sitelib}/bzrlib/plugins/*

Ditto

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.