[Bug 580169] Review Request: loggerhead - Web viewer for the Bazaar version control system

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 8 04:44:07 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580169

--- Comment #2 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-04-08 00:44:03 EDT ---
(In reply to comment #1)
> README.mod_wsgi seems wrong, there are no /etc/bazaar.conf in the package.
> 
Fixed.  Now says: /etc/loggerhead/bazaar.conf.

> In loggerhead.conf, is it right to comment out this line
> 
> #Alias /bzr/static /usr/share/loggerhead/static
>
Uncommented.  This was broken earlier but I fixed the root cause so it works
now.

> Is this line correct:
> 
>  WSGIScriptAlias /bzr /var/www/cgi-bin/loggerhead.wsgi
> 
Also a good catch.  Changed to /usr/bin/loggerhead.wsgi

> 
> About the spec file:
> 
>  cp -p %{SOURCE4} %{buildroot}/%{_bindir}/
> 
> use install command here and drop %attr in %files.
> 
> mkdir -p %{buildroot}/%{_sysconfdir}/loggerhead/
> cp -p %{SOURCE3} %{buildroot}/%{_sysconfdir}/loggerhead/
> 
> more simple and robust:
> 
> install -D -m 0644 -p %{SOURCE3}
> %{buildroot}/%{_sysconfdir}/loggerhead/bazaar.conf
>
Done.  Though I've noticed that you've made a point of asking people to change
cp to install several times.  This is not a guideline and there are times when
it doesn't make sense:
  https://www.redhat.com/archives/fedora-extras-list/2005-May/msg00452.html

> 
> %attr(0755,root,root) %{_bindir}/*
> %{_mandir}/man1/*
> 
> Explicit please.
> 
> %{python_sitelib}/bzrlib/plugins/*
> 
> Ditto    

Implicit is unavoidable without jumping through hoops (Every directory listed
in %files is an implicit wildcard), isn't a guideline, and doesn't have an
overwhelming benefit.

SRPM: http://toshio.fedorapeople.org/packages/loggerhead-1.17-2.fc12.src.rpm
SPEC: http://toshio.fedorapeople.org/packages/loggerhead.spec
Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2101972

* Wed Apr 07 2010 Toshio Kuratomi <toshio at fedoraproject.org> - 1.17-2
- Fix comments in review.
- Fix a traceback for the download and diff ui pages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list