[Bug 568833] Review Request: OpenLP - Church projection software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=568833

--- Comment #18 from Nils Philippsen <nphilipp at redhat.com> 2010-04-08 11:55:59 EDT ---
- GOOD/CHECK: rpmlint doesn't find serious issues:

nils at gibraltar:~/devel/fedora-review/OpenLP> rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/OpenLP-1.9.1.1-1.fc14.noarch.rpm
OpenLP.noarch: W: spelling-error %description -l en_US openoffice -> open
office, open-office, interoffice

-> see below

OpenLP.noarch: W: incoherent-version-in-changelog 1.9.1.1 ['1.9.1.1-1.fc14',
'1.9.1.1-1']

-> bogus

OpenLP.noarch: W: hidden-file-or-dir
/usr/lib/python2.6/site-packages/openlp/.version

-> I'd do that differently, see my last comment. Ping me if you have questions
about that.

1 packages and 0 specfiles checked; 0 errors, 3 warnings.

- BAD/CHECK: The description contains grammar errors: "OpenLP is a church
presentation software, for lyrics projection software, ...", rpmlint complains
about "openoffice", should be "OpenOffice.org", e.g.:

OpenLP is a church presentation software and lyrics projection software,
used to display slides of songs,  Bible verses, videos, images, and 
presentations (if OpenOffice.org is installed) using a computer and a data
projector.

- GOOD: Owns all directories it creates.
- GOOD: disttag added
- GOOD: /usr/bin/python used
- GOOD: .pyw extension dropped

This package is APPROVED. Please proceed with requesting CVS branches, you
should be sponsored for packager shortly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.