[Bug 580849] Review Request: mktorrent - Command line utility to create BitTorrent metainfo files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580849

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no

--- Comment #1 from Terje Røsten <terjeros at phys.ntnu.no> 2010-04-09 08:05:28 EDT ---
o Mixing of %{foo} $FOO style macros: use $RPM_OPT_FLAGS and $RPM_BUILD_ROOT or
%{optflags} and %{buildroot}

o PREFIX=$RPM_BUILD_ROOT%{_usr} you might want to change to
PREFIX=$RPM_BUILD_ROOT%{_prefix}


o Remove empty lines in %description, add empty line between changelog entries.


o is USE_LARGE_FILES=1 needed on 32 bits?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.