[Bug 480607] Review Request: bluecove - Implementation of JSR-82 Java Bluetooth API

bugzilla at redhat.com bugzilla at redhat.com
Fri Apr 9 23:02:43 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480607

--- Comment #11 from Orion Poplawski <orion at cora.nwra.com> 2010-04-09 19:02:33 EDT ---
    *  rpmlint

 rpmlint bluecove-debuginfo
bluecove-debuginfo.i686: E: debuginfo-without-sources

Looks like the source is not making it info the debuginfo package for some
reason.

    * naming - OK
    * NamingGuidelines - OK
    * licensing - 

Looks like that there are still some files (e.g. BlueCoveBlueZ_RFCOMMServer.c)
under the LGPLv2+ license.  I don't think that is an issue but I think it needs
to be mentioned in the spec and perhaps brought to the attention of upstream.

    * osi approved? - OK
    * included? - OK 
    * correct mentioned in specfile? - NO 

specfile

    * American English - OK
    * legible - OK
    * ExcludeArch, blocking - OK
    * BuildRequires - OK
    * Locales - OK
    * shared libraries: ldconfig - OK
    *  %clean section with rm -rf ${RPM_BUILD_ROOT} - OK
    * macros - OK
    * sources - OK
    * relocatable? Prefix: /usr? - OK
    * files and directories - OK
    * owns all created directories - OK
    * all files listed in %files - OK
    * permissions? - OK
    * deffattr? - OK
    * no .la files - OK
    * .desktop for GUI applications - OK
    * no conflicts with other packages - OK
    * -devel - NA
    * permissable content - OK
    * doc - OK 
    * large doc in -doc package - OK
    * must not affect runtime  - OK

    * mock build - http://koji.fedoraproject.org/koji/taskinfo?taskID=2106889
OK
    * sane scriptlets - OK
    * subpackages with fully versioned dependency - NA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list