[Bug 545405] Review Request: goldendict - A feature-rich dictionary lookup program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545405

--- Comment #21 from Liberty <liberty at live.com> 2010-04-09 21:34:51 EDT ---
Thank you very much for your suggestion. 

? git based source
There is a stability bug in the 0.9 stable version. I have asked the author
about this and the author suggest me to use git version. Also I have tested for
months and the git version is more stable than 0.9 version.

! BuildRoot
If I delete buildroot line, the rpmlint will give me a warning about the
non-presence of buildroot.

* BR
Right, it is unnecessary.

! Idendation
Right, I have added the indentation.

* desktop file
I have just follow the guide which recommend people to validate it. For the
goldendict.png issue, Do I need to use a patch file to fix it?

* install usage
Yes -D is not useful.

* $RPM_BUILD_ROOT vs %buildroot
Yes, I have fixed this issue.

* Directory ownership issue
Thank you for indicating this issue. I have fixed it.

New SPEC:
http://fantastischmemo.xtreemhost.com/goldendict.spec

New SRPM:
https://koji.fedoraproject.org/koji/getfile?taskID=2107104&name=goldendict-0.9.0-7.20100307git83115ad.fc14.src.rpm

New koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=2107101

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.