[Bug 580169] Review Request: loggerhead - Web viewer for the Bazaar version control system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580169

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Terje Røsten <terjeros at phys.ntnu.no> 2010-04-10 08:28:46 EDT ---

ok rpmlint (a warning which can be ignored)
    loggerhead.noarch: W: hidden-file-or-dir /var/www/.bazaar
    2 packages and 0 specfiles checked; 0 errors, 1 warnings.
ok spec file, change these to full names if you want.
   %{_bindir}/*
   %{_mandir}/man1/*
ok name and naming
ok patches upstream
ok license is valid and set correct, some files don't have license info
    (controllers/filediff_ui.py , controllers/revlog_ui.py,
     middleware/profile.py, apps/config.py , apps/__init__.py
     tests/*.py) Please consider to notify upstream about this issue.
ok lang
ok dirs, perms and owns
ok tarball
    cdddaf4497bb9632f9c9ea90b4713c09  loggerhead-1.17.tar.gz
    cdddaf4497bb9632f9c9ea90b4713c09  loggerhead-1.17.tar.gz.spec
ok koji build
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2107537

ok function, serve-branches seems to work ok. 
    I can't get mod_wsgi to load config (no selinux), 
    I get this in the log:

mod_wsgi (pid=18927): Target WSGI script '/usr/bin/loggerhead.wsgi' cannot be
loaded as Python module.
 mod_wsgi (pid=18927): Exception occurred processing WSGI script
'/usr/bin/loggerhead.wsgi'.
 Traceback (most recent call last):
   File "/usr/bin/loggerhead.wsgi", line 28, in <module>
     {'user': pwd.getpwuid(os.geteuid()).pw_name})
 NotConfiguredError: You must have a ~/.bazaar/bazaar.conf file for apache with
http_root_dir set to the base directory you want to serve bazaar repositories
from

mod_wgsi being optional and not default enabled I don't fine any more issues
and the package loggerhead is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.