[Bug 581161] Review Request: cowpatty - Audit WPA pre-shared keys

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581161

Dominic Hopf <dmaphy at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmaphy at fedoraproject.org

--- Comment #1 from Dominic Hopf <dmaphy at fedoraproject.org> 2010-04-10 13:59:01 EDT ---
A few quick notes on your specfile:
* You should use macros in the Source URL in line 9:
  http://wirelessdefence.org/Contents/Files/%{name}-%{version}.tgz
* I think using the macro in the description (line 14) is not an appropriate
elegant solution
* You should use make, rm and install directly instead of the macros (lines 25,
28, 29, 30 and 34)
* The BuildRoot-tag in line 10 is not necessary anymore as per guideline [1],
you can remove it at your   
  option unless you like to push your package also in EPEL
* You can use the name macro in the target paths in lines 29 and 40 instead of
writing "cowpatty"
* You have 79 chars per line for your description, but you're actually using
just 53 per line. Maybe you like 
  to improve that :)

[1] http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.