[Bug 581161] Review Request: cowpatty - Audit WPA pre-shared keys
bugzilla at redhat.com
bugzilla at redhat.com
Sat Apr 10 20:54:17 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581161
Christoph Wickert <cwickert at fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cwickert at fedoraproject.org
--- Comment #3 from Christoph Wickert <cwickert at fedoraproject.org> 2010-04-10 16:54:16 EDT ---
Hi Arun, thanks for helping us with the security spin.
Some comments on the macros in your spec. I have to say I don't full agree with
Dominic. Generally speaking you should use macros where it makes things easier
for you, for example for things that change a lot or for code that can be
shared between spec files.
For example I maintain a lot of xfce4-panel plugins and all have a page in the
Xfce wiki, so I can use
http://goodies.xfce.org/projects/panel-plugins/%{name}
while I normally would use the full URL.
> %{name} is designed to audit the pre-shared key (PSK)
no need to use a macro here as this only appears once in the spec, will never
change and cannot be copied over to another spec.
> %{_bindir}/cowpatty
Here it might make sense to use %{_bindir}/%{name} because it is a common
phrase in many specs.
Please don't use macros for trivial things like %{__install} or %{__rm}. This
has recently been discussed on the devel mailing list:
http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list