[Bug 551587] Review Request: java-gnome - Java GNOME bindings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551587

--- Comment #14 from Mat Booth <fedora at matbooth.co.uk> 2010-04-11 09:08:07 EDT ---
Ok, if upstream are not worried about it, then I'm not worried about it. :-)

As for a more formal review, the package in general is very good. Rpmlint is
clean and the package works (I tried the libnotify example). Thanks for noting
in the SPEC why parallel make is not used and including a bugzilla link for the
patch. The only *must* guideline that is not followed is this one:

* On the Java guidelines page, it states that if the project name (java-gnome)
and the common jar name (gtk) differ, then symlinks must be provided to provide
jars with both names.
http://fedoraproject.org/wiki/Packaging:Java#Jar_file_naming

Other nit-picks:

* The javadoc sub-package could (should?) be noarch.
* It's usual to include an unversioned symlink to the Javadocs so that
bookmarks continue to work after updates, etc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.