[Bug 573932] Review Request: perl-IO-Compress - IO::Compress Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573932

--- Comment #13 from Chris Weyl <cweyl at alumni.drew.edu> 2010-04-11 14:04:37 EDT ---
Alright!  So. :)

The invocation of %{?perl_default_filter} needs to be done before the first
%description stanza in the spec file.  If you're not invoking any other
filtering macros, the %{?perl_default_filter} incantation is sufficiently
conditionalized without wrapping it in %{?filter_setup: ... }.

Looks like we need Test::Pod; and t/020isize.t needs COMPRESS_ZLIB_RUN_ALL=1
set and Test::NoWarnings BR'ed to run all its tests.

%files needs a '%exclude %dir %{perl_archlib}/auto'.  There's an examples/
directory in the tarball; why not include it under %doc?  Similarly, theres a
pod/FAQ.pod.

The %description is a touch misleading, as modules like IO::Compress::Gzip are
most certainly intended to be used by application code.  Perhaps the part
under "DESCRIPTION" in the README would work better?

And, it looks like this is being built as "noarch" but is still installing
(and packaging) files under the arch-specific %perl_archlib...  which is not
entirely optimal :)  The files should either be under %perl_privlib or the
package should be built for each supported architecture.

Update as described above, and I'll approve :)

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2108542

Spec looks clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
20329a7c1a1eac90f4f60735f15829e0a915c429 IO-Compress-2.024.tar.gz
20329a7c1a1eac90f4f60735f15829e0a915c429 IO-Compress-2.024.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-IO-Compress-2.024-2.fc14.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-IO-Compress-2.024-2.fc14.noarch.rpm
perl(Compress::Zlib) = 2.024
perl-Compress-Zlib = 2.024-2.fc14
perl(File::GlobMapper) = 1.000
perl-IO-Compress = 2.024-2.fc14
perl(IO::Compress::Adapter::Bzip2) = 2.024
perl(IO::Compress::Adapter::Deflate) = 2.024
perl(IO::Compress::Adapter::Identity) = 2.024
perl(IO::Compress::Base) = 2.024
perl-IO-Compress-Base = 2.024-2.fc14
perl(IO::Compress::Base::Common) = 2.024
perl(IO::Compress::Bzip2) = 2.024
perl-IO-Compress-Bzip2 = 2.024-2.fc14
perl(IO::Compress::Deflate) = 2.024
perl(IO::Compress::Gzip) = 2.024
perl(IO::Compress::Gzip::Constants) = 2.024
perl(IO::Compress::RawDeflate) = 2.024
perl(IO::Compress::Zip) = 2.024
perl(IO::Compress::Zip::Constants) = 2.024
perl-IO-Compress-Zlib = 2.024-2.fc14
perl(IO::Compress::Zlib::Constants) = 2.024
perl(IO::Compress::Zlib::Extra) = 2.024
perl(IO::Uncompress::Adapter::Bunzip2) = 2.024
perl(IO::Uncompress::Adapter::Identity) = 2.024
perl(IO::Uncompress::Adapter::Inflate) = 2.024
perl(IO::Uncompress::AnyInflate) = 2.024
perl(IO::Uncompress::AnyUncompress) = 2.024
perl(IO::Uncompress::Base) = 2.024
perl(IO::Uncompress::Bunzip2) = 2.024
perl(IO::Uncompress::Gunzip) = 2.024
perl(IO::Uncompress::Inflate) = 2.024
perl(IO::Uncompress::RawInflate) = 2.024
perl(IO::Uncompress::Unzip) = 2.024
perl(U64)  
perl(Zlib::OldDeflate)  
perl(Zlib::OldInflate)  
====> requires for perl-IO-Compress-2.024-2.fc14.noarch.rpm
perl >= 0:5.004
perl(AutoLoader)  
perl(bytes)  
perl(Carp)  
perl(Compress::Raw::Bzip2) >= 2.024
perl(Compress::Raw::Zlib) >= 2.024
perl(constant)  
perl(Exporter)  
perl(File::GlobMapper)  
perl(IO::Compress::Adapter::Bzip2) >= 2.024
perl(IO::Compress::Adapter::Deflate) >= 2.024
perl(IO::Compress::Adapter::Identity) >= 2.024
perl(IO::Compress::Base) >= 2.024
perl(IO::Compress::Base::Common) >= 2.024
perl(IO::Compress::Gzip) >= 2.024
perl(IO::Compress::Gzip::Constants) >= 2.024
perl(IO::Compress::RawDeflate) >= 2.024
perl(IO::Compress::Zip::Constants) >= 2.024
perl(IO::Compress::Zlib::Constants) >= 2.024
perl(IO::Compress::Zlib::Extra) >= 2.024
perl(IO::File)  
perl(IO::Handle)  
perl(IO::Seekable)  
perl(IO::Uncompress::Adapter::Bunzip2) >= 2.024
perl(IO::Uncompress::Adapter::Identity) >= 2.024
perl(IO::Uncompress::Adapter::Inflate) >= 2.024
perl(IO::Uncompress::Base) >= 2.024
perl(IO::Uncompress::Gunzip) >= 2.024
perl(IO::Uncompress::Inflate) >= 2.024
perl(IO::Uncompress::RawInflate) >= 2.024
perl(IO::Uncompress::Unzip) >= 2.024
perl(List::Util)  
perl(:MODULE_COMPAT_5.10.1)  
perl(POSIX)  
perl(Scalar::Util)  
perl(strict)  
perl(Symbol)  
perl(utf8)  
perl(warnings)  

=====> perl-IO-Compress-2.024-2.fc14.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-IO-Compress-2.024-2.fc14.src.rpm
====> requires for perl-IO-Compress-2.024-2.fc14.src.rpm
perl(Compress::Raw::Bzip2) >= 2.024
perl(Compress::Raw::Zlib) >= 2.024
perl(ExtUtils::MakeMaker)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.