[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545720

--- Comment #30 from Christoph Wickert <cwickert at fedoraproject.org> 2010-04-12 05:25:30 EDT ---
(In reply to comment #27)
> All suggestions applied:

You are still using the prebuilt locales. I think they will be built when if
you remove them. There also seems to be an option to overwrite them, take a
look at setup.py.

> Note: since the python setup.py installs the icon file in
> %{_datadir}/icons/googsystray.png , i chose to rm it in the %install section

I would prefer a patch here because this is something that you can also send to
upstream. In Fedora we try to take care of upstreaming our changes.

> No idea why the build line was there twice. 

It's not there twice, but --skip-build was missing in the setup.py call in
%install.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.