[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545720

--- Comment #31 from Leon Keijser <keijser at stone-it.com> 2010-04-13 02:02:58 EDT ---
(In reply to comment #30)
> You are still using the prebuilt locales. I think they will be built when if
> you remove them. There also seems to be an option to overwrite them, take a
> look at setup.py.

Okay, i have included an extra line in the %build section:

python setup.py i18n --force

right before the 'build' command. Comparing the resulting locale files'
timestamp, they now seem to be built correctly.

> > Note: since the python setup.py installs the icon file in
> > %{_datadir}/icons/googsystray.png , i chose to rm it in the %install section
> 
> I would prefer a patch here because this is something that you can also send to
> upstream. In Fedora we try to take care of upstreaming our changes.

Could you help me with the reason for this? I'm willing to contact upstream and
ask him for the changes, but i'm not sure why :)  From
http://fedoraproject.org/wiki/Packaging:Guidelines#Filesystem_Layout i looked
at
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENTDATA
but can't find the pixmaps dir (or icon dir, for that matter) specified.


> > No idea why the build line was there twice. 
> 
> It's not there twice, but --skip-build was missing in the setup.py call in
> %install.    

Now i see what you meant. I've modified the line in the %install section to
match your suggestion.

http://leon.fedorapeople.org/files/googsystray/googsystray.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.