[Bug 581104] Review Request: lv2-EQ10Q-plugins - Parametric equalizer lv2 plugin

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 13 06:26:39 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581104

--- Comment #6 from David Cornette <rpm at davidcornette.com> 2010-04-13 02:26:34 EDT ---
Based on some comments I received on #fedora-devel, I have made 3 changes.

* I changed the Source0: listing, I replaced the literal 1.0 version in the
tarball name with the %{version} macro.

* One of the classes, vuwidget, is under GPLv3+, while the rest is under
GPLv2+.  The vuwidget class is only linked into one of the two libraries,
parameq_gui.so, while the other library, paramEQ.so, contains only GPLv2+ code.
 Therefore I have set the license field to "GPLv2+ and GPLv3+".

* I have patched the Makefile so that the optimization flags were not hard
coded, and could be overridden with the %{optflags} macro.

Spec File: http://www.davidcornette.com/lv2-EQ10Q-plugins.spec
SRPM URL: http://www.davidcornette.com/lv2-EQ10Q-plugins-1.0-3.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list