[Bug 563000] Review Request: rubygem-compass - A Sass-based CSS Meta-Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563000

--- Comment #2 from Mohammed Morsi <mmorsi at redhat.com> 2010-04-14 11:54:24 EDT ---
Spec updated based on feedback and new version uploaded:
Spec URL: http://mo.morsi.org/files/gems/rubygem-compass.spec
SRPM URL: http://mo.morsi.org/files/gems/rubygem-compass-0.8.17-2.fc11.src.rpm 

rpmlint rpmbuild/RPMS/noarch/rubygem-compass-0.8.17-1.fc11.noarch.rpm 
rpmbuild/SRPMS/rubygem-compass-0.8.17-1.fc11.src.rpm
rpmbuild/SPECS/rubygem-compass.spec 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.



(In reply to comment #1)
> File listed twice:
> /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/LICENSE.markdown
> /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/README.markdown

These two files are different (LICENSE, README) and rpmlint isn't complaining
about any duplicate files. Can you elaborate if this is still an issue?


> ----
> Tests are not executed (./tests)

Fixed.

> ----
> Do not use %define, use %global

Fixed.

> ----
> ./docs are not installed (not listed in %files)    

The docs are included as the last entry in %files, 

%doc %{gemdir}/doc/%{gemname}-%{version}

Were you looking for other docs, if so which ones?

Also resolved the issue w/ the misspelled macros above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.