[Bug 563000] Review Request: rubygem-compass - A Sass-based CSS Meta-Framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563000

--- Comment #4 from Mohammed Morsi <mmorsi at redhat.com> 2010-04-14 13:02:03 EDT ---
(In reply to comment #3)
> Just comment for this:
> 
> (In reply to comment #2)
> > (In reply to comment #1)
> > > File listed twice:
> > > /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/LICENSE.markdown
> > > /usr/lib/ruby/gems/1.8/gems/compass-0.8.17/README.markdown
> > 
> > These two files are different (LICENSE, README) and rpmlint isn't complaining
> > about any duplicate files. Can you elaborate if this is still an issue?
> 
> Note that %files entry
> -------------------------------------------------
> %files
> foo/
> -------------------------------------------------
> contains the directory foo/ itself _and_ all files/directories/etc
> under the directory foo, and %{gemdir}/gems/%{gemname}-%{version}/
> (in %files entry) is the same as %{geminstdir} 
> (by the as you defined %geminstdir, please use this macro in %files),
> while
> -------------------------------------------------
> %files
> %dir foo/
> -------------------------------------------------
> contains the directory foo/ only.    

Fixed.

Spec updated based on feedback and new version uploaded:
Spec URL: http://mo.morsi.org/files/gems/rubygem-compass.spec
SRPM URL: http://mo.morsi.org/files/gems/rubygem-compass-0.8.17-3.fc11.src.rpm 

rpmlint rpmbuild/SPECS/rubygem-compass.spec
rpmbuild/SRPMS/rubygem-compass-0.8.17-3.fc11.src.rpm
rpmbuild/RPMS/noarch/rubygem-compass-0.8.17-3.fc11.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2115523

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.