[Bug 580873] Review Request: libdb - Oracle Berkeley DB version 5

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 15 08:52:23 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580873

Jaroslav Škarvada <jskarvad at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #1 from Jaroslav Škarvada <jskarvad at redhat.com> 2010-04-15 04:52:22 EDT ---
[NO] rpmlint is silent.
libdb-cxx.x86_64: W: no-documentation
> Probably OK.
libdb-cxx.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_cxx-5.0.so
0775
> 0755?
libdb-devel-static.x86_64: W: spelling-error %description -l en_US statical ->
statically, statistical, static
> First and third variants sounds better.
libdb-devel-static.x86_64: W: no-documentation
> Probably OK.
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/examples_c/bench_001.c
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/LoadIndexKeywords.aspx
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/SearchHelp.aspx
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/styles/Whidbey/presentation.css
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/scripts/Dropdown.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/scripts/EventUtilities.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/scripts/highlight.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/scripts/script_feedBack.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/scripts/script_manifold.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/scripts/CommonUtilities.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/styles/Presentation.css
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/TOC.css
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/Index.aspx
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/scripts/CheckboxMenu.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/Web.Config
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/TOC.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/WebTOC.xml
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/WebKI.xml
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/scripts/SplitScreen.js
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/FillNode.aspx
libdb-devel.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/libdb-devel-5.0.21/csharp/styles/highlight.css
> Mostly cosmetic, worth to fix? 
libdb-java.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_java-5.0.so
0775
> 0755?
libdb-sql.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dbsql
['/usr/lib64']
> rpath should be killed.
libdb-sql.x86_64: W: no-documentation
> Probably OK.
libdb-sql.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_sql-5.0.so
0775
> 0755?
libdb-sql.x86_64: W: devel-file-in-non-devel-package /usr/include/libdb/dbsql.h
> libdb-sql-devel for one file or OK as is?
libdb-tcl.x86_64: W: no-documentation
> Probably OK.
libdb-tcl.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_tcl-5.0.so
0775
> 0755?
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_printlog
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_dump
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_archive
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_deadlock
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_log_verify
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_upgrade
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_load
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_recover
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_verify
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_stat
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_checkpoint
['/usr/lib64']
libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_hotbackup
['/usr/lib64']
> rpath should be killed.
libdb-utils.x86_64: W: no-documentation
> Probably OK.
libdb.x86_64: E: non-standard-executable-perm /lib64/libdb-5.0.so 0775
> 0755?
10 packages and 0 specfiles checked; 18 errors, 28 warnings.

[YES] Package meets naming guidelines.
> Please use integer release if pushed to CVS.
[YES] Package meets packaging guidelines.
> Looks OK.
[YES] Spec file matches base package name.
[YES] License file is present, matching with spec file.
[YES] Licensing Guidelines are met.
[YES] Spec file is legible and in American English.
[YES] Sources match upstream.
[YES] Package builds OK.
[YES] BuildRequires is correct.
> There is no need to list util-linux-ng, see exception.
> It builds in mock, thus at least nothing missing here.
[?] ldconfig is called in %post/%postun for every package with DSO
> It seems the ldconfig is not called for cxx subpackage.
[YES] Package doesn't bundle copies of system libraries.
[YES] Package owns all the directories it creates.
> Looks OK.
[YES] Package has no duplicity in %files.
> Looks OK.
[NO] Permission on files are set properly.
> deffatr should be (-,root,root,-).
> Some libraries are installed with mode 0775, see rpmlint output above.
[N/A] Package has correctly installed .desktop file.
[YES] %clean section is correct.
[YES] Spec file has consistant macro usage.
[YES] Package is code or permissable content.
[YES] %doc files don't affect runtime.
> Looks OK.
[NO] Header files must be in a -devel package.
> libdb-sql-devel for /usr/include/libdb/dbsql.h or OK as is? Same as the rpmlint output above.
[YES] Static libraries must be in a -static package.
[YES] If a package contains library files with a suffix, then library files
that end in .so must go in a -devel package.
[NO] Devel packages must require the base package using a fully versioned
dependency.
> There is no dependency in devel-static subpackage.
> Missing dependency for cxx subpackage, is that OK?
[YES] No .la libtool archives.
[YES] Package doesn't own files/directories that other packages own.
[YES] Package has rm -rf $RPM_BUILD_ROOT at beginning of %install.
[YES] All files including spec are valid UTF-8

Should items:
[YES] Package builds in mock.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list