[Bug 580964] Review Request: python-greenlet - Lightweight in-process concurrent programming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580964

Kevin Fenzi <kevin at tummy.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Kevin Fenzi <kevin at tummy.com> 2010-04-15 16:37:10 EDT ---

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (MIT)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
8d75d7f3f659e915e286e1b0fa0e1c4d  greenlet-0.3.1.tar.gz
8d75d7f3f659e915e286e1b0fa0e1c4d  greenlet-0.3.1.tar.gz.orig

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Headers/static libs in -devel subpackage. 
OK - -devel package Requires: %{name} = %{version}-%{release}

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have subpackages require base package with fully versioned depend. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. rpmlint says: 

python-greenlet.src: W: spelling-error %description -l en_US tasklets -> task
lets, task-lets, anklets
python-greenlet.src: W: spelling-error %description -l en_US Tasklets -> Task
lets, Task-lets, Anklets
python-greenlet.x86_64: W: spelling-error %description -l en_US tasklets ->
task lets, task-lets, anklets
python-greenlet.x86_64: W: spelling-error %description -l en_US Tasklets ->
Task lets, Task-lets, Anklets
python-greenlet-devel.x86_64: W: no-documentation

All can be ignored. 

2. I'm not sure about having the devel subpackage. Sure there is a header file,
but 
as you said nothing really uses it. I suppose it doesn't hurt, but seems like a
waste. 

3. There are included tests, could be worth adding them to %check section?
(They run ok here with a 'python setup.py test')

I don't see any blockers here, so this package is APPROVED. 
Consider the test point before importing if you like. 

Also, if you would like co-maintainers, I would be happy to help co-maintain.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.