[Bug 581619] Review Request: mlterm - Multi Lingual TERMinal emulator on X

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581619

--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2010-04-16 10:50:54 EDT ---
First of all, please bump the release number every time you provide an updated
spec file. Otherwise it's hard to distinguish between the various versions.

Replace "%define pixmapdir /usr/share/pixmaps" with "%global pixmapdir
%{_datadir}/pixmaps"

Fix Source0 according to
http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

The allowed license tags are listed here:
http://fedoraproject.org/wiki/Licensing. The file LICENSE contains the BSD
license text (3 clause variant), so the corresponding license tag should be
BSD. However, folder "inputmethod" contains several files licensed under
LGPLv2+ and MIT. Thus, the resulting License for the package is "BSD and
LGPLv2+ and MIT" if everything goes to one package.

Instead of calling configure directly, you should use the macro %configure
which automatically applies the correct directories. In this case you can drop
the CFLAGS and --FOOdir=%{_FOOdir} lines.

The locale files must be properly added using %find_lang. See
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files for
further information

The .desktop file must be installed with desktop-file-install or
desktop-file-validate (see
http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files)

Use the code snippets from
http://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache
for updating the GTK+ icon cache

Change %defattr(-,root,root) to %defattr(-,root,root,-)

If the bundled libraries libkik and libmkf are only relevant for the mlterm
binaries, and not used for further third-party packages, they can stay in the
base package. In this case you should remove the development files libkik.so
and libmkf.so. However, it might be better to put the two libraries in separate
subpackages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.