[Bug 577398] Review Request: python-meliae - Python memory usage statistics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577398

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
               Flag|                            |fedora-review+

--- Comment #6 from Thomas Spura <tomspur at fedoraproject.org> 2010-04-16 14:36:43 EDT ---
Review:

Good:
- sources match upstream: 21846ab82299ae1e30d3123a92a05ac0
- name ok
- %build/%install ok
- %clean there
- license ok - it's GPLv3 and *NOT* GPLv3+
- Group ok
- arch ok
- koji ok:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2121545


Needswork:
- Could you be a bit more verbose in %files, to detect, if the egg was
correctly build?
e.g.
%{python_sitearch}/meliae
%{python_sitearch}/meliae-*-py?.?.egg-info

- %check missing:
%check
./run_tests.py
doesn't work here, but python setup.py build --inplace doesn't either, don't
know why.
python setup.py build_ext --inplace worked. Could this be a distutils/cython
bug?


- Great patch comment. Is it upstream? No comment about that.

(In reply to comment #5)
> Thanks for the quick response.  Changing Py_ssize_t to ssize_t did remove a
> number of errors, but now I'm blocked on errors related to Sets.  I'm thinking
> that at this point it's probably not worth trying to backport to Python 2.4.    

See TODO.txt:
'''
8) Full cross-platform and version compatibility.

   I'd like to support python2.4+, 32/64-bit, Win/Linux/Mac. I've tested
   a couple variants, but I don't have all of them to make sure it works
   everywhere.
'''

Maybe it will be supported in the future.


###############################################################################

Only shoulds/coulds left (see Needswork).

###############################################################################


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.