[Bug 581341] Review Request: maildirproc - Sort mail from mail boxes in the maildir format

bugzilla at redhat.com bugzilla at redhat.com
Fri Apr 16 21:08:20 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581341

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review+

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-04-16 17:08:15 EDT ---
Review:

Good:
- name ok (even without a 'py' in it *harr*)
- rest of specfile ok
  * %build/%install ok
  * %files ok
  * %clean there
- group ok
- license ok (GPLv2+)
$ rpmlint ./maildirproc-0.4.2-1.fc13.src.rpm
noarch/maildirproc-0.4.2-1.fc13.noarch.rpm 
maildirproc.src: W: spelling-error Summary(en_US) maildir -> Mailer, mailer,
mailing
maildirproc.src: W: spelling-error %description -l en_US maildir -> Mailer,
mailer, mailing
maildirproc.src: W: spelling-error %description -l en_US procmail -> proclaim
maildirproc.noarch: W: spelling-error Summary(en_US) maildir -> Mailer, mailer,
mailing
maildirproc.noarch: W: spelling-error %description -l en_US maildir -> Mailer,
mailer, mailing
maildirproc.noarch: W: spelling-error %description -l en_US procmail ->
proclaim
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

Than can't be avoided -> ignorable

- builds in mock
INFO: Done(maildirproc-0.4.2-1.fc13.src.rpm) Config(default) 2 minutes 19
seconds

- sources match upstream sha512:
ab3d56383b7d6bea7abc0ecb510a4b969c7b26f812965fcd8aaa98ce69ded7e90470e229c81378757f15c38346b02fbacfd2a8a3438eb3eafdf5e364c9d4b9c9


Couldwork:
- python2-devel is better than python-devel (no need to get changed, once
python-devel will be python3-devel). If you left anything as it it, this
package will be build with/against and will automatically require python3 after
a rebuild.

Choose if you want to stick with python2 forever or change with the default.


###############################################################################

Only 'coulds' left.

###############################################################################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list