[Bug 546686] Review Request: cricscore-applet - Cricket score applet for gnome panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546686

--- Comment #4 from Ankur Sinha <sanjay.ankur at gmail.com> 2010-04-17 10:28:28 EDT ---
complete review:

+ = OK
- = NA
? = issue


+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.

+ Sources match upstream md5sum:
[Ankur1 at localhost rpmbuild]$ md5sum cricscore-1.1.0.2.tar.gz 
fcd9a577640e1f25c45a24b40f93e476  cricscore-1.1.0.2.tar.gz
[Ankur1 at localhost rpmbuild]$ md5sum SOURCES/cricscore-1.1.0.2.tar.gz 
fcd9a577640e1f25c45a24b40f93e476  SOURCES/cricscore-1.1.0.2.tar.gz


- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

? Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2122121

+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.

- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
+ Should function as described.
+ Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)


XXXX Issues XXXX

1. use parallel make?
https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

2. since its a GUI, I think a desktop file is needed. 
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

Please make a desktop file as SOURCE1 and also submit this upstream?

3. rpmlint gives some errors:
[Ankur1 at localhost SOURCES]$ rpmlint 
~/Downloads/cricscore-applet-1.1.0.2-2.fc12.noarch.rpm 
cricscore-applet.noarch: E: script-without-shebang
/usr/libexec/cricscore-applet/cricscore_prefs.py
cricscore-applet.noarch: E: script-without-shebang
/usr/libexec/cricscore-applet/gnome_cricscore_globals.py
cricscore-applet.noarch: E: script-without-shebang
/usr/lib/bonobo/servers/cricketscore.server
cricscore-applet.noarch: E: script-without-shebang
/usr/share/cricscore-applet/GNOME_CricScoreApplet.xml
1 packages and 0 specfiles checked; 4 errors, 0 warnings.

trivial fix:
http://fedoraproject.org/wiki/Packaging_tricks#Add_shebang


These are all. Once these are fixed, you're good to go ! :)

regards,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.