[Bug 583251] Review Request: dcfldd - Improved dd, useful for forensics and security

Sat Apr 17 18:04:17 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=583251

Terje RÃ¸sten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros at phys.ntnu.no

--- Comment #2 from Terje RÃ¸sten <terjeros at phys.ntnu.no> 2010-04-17 14:04:12 EDT ---
Some quick comments:

 o use %global over %define (and move it to the top).
 o not needed to add gcc-c++ and  libstdc++-devel to buildreq, remove.
 o change source tag to source0
 o add INSTALL='install -p' to make install to preserve timestamps
 o change %defattr(-, root, root, 0755) to %defattr(-, root, root, -)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.