[Bug 546686] Review Request: cricscore-applet - Cricket score applet for gnome panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546686

--- Comment #7 from Ankur Sinha <sanjay.ankur at gmail.com> 2010-04-17 14:22:17 EDT ---
(In reply to comment #6)
> (In reply to comment #4)
> 
> > XXXX Issues XXXX
> > 
> > 1. use parallel make?
> > https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
> > 
> 
> 
> Will make use of the macro %{_smp_mflags}
> 
> > 2. since its a GUI, I think a desktop file is needed. 
> > https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
> > 
> > Please make a desktop file as SOURCE1 and also submit this upstream?
> > 
> 
> Not needed? I checked another panel applet named deskbar, it does not have any
> .desktop files. Do i still need to add a .desktop file?
> 

yeah, checked, not needed. 

> 
> > 3. rpmlint gives some errors:
> > [Ankur1 at localhost SOURCES]$ rpmlint 
> > ~/Downloads/cricscore-applet-1.1.0.2-2.fc12.noarch.rpm 
> > cricscore-applet.noarch: E: script-without-shebang
> > /usr/libexec/cricscore-applet/cricscore_prefs.py
> > cricscore-applet.noarch: E: script-without-shebang
> > /usr/libexec/cricscore-applet/gnome_cricscore_globals.py
> > cricscore-applet.noarch: E: script-without-shebang
> > /usr/lib/bonobo/servers/cricketscore.server
> > cricscore-applet.noarch: E: script-without-shebang
> > /usr/share/cricscore-applet/GNOME_CricScoreApplet.xml
> > 1 packages and 0 specfiles checked; 4 errors, 0 warnings.
> > 
> > trivial fix:
> > http://fedoraproject.org/wiki/Packaging_tricks#Add_shebang
> > 
> 
> Will fix.    

please upload the final srpm, and we can finish up this review :)

Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.