[Bug 583141] Review Request: nautilus-pastebin - Nautilus extension to send files to a pastebin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583141

--- Comment #4 from Ankur Sinha <sanjay.ankur at gmail.com> 2010-04-17 15:11:23 EDT ---
Hey!

(In reply to comment #3)
> Arrg...
> 
> - Why should there be a debuginfo package? There are only python scripts and so
> on.
>   -> BuildArch:    noarch
> 
> - 46 # not too sure about this
>   47 chmod a+x $RPM_BUILD_ROOT/%{python_sitelib}/pastebin/core.py
> 
>   You should remove the /usr/bin/python in that file, because it doesn't need
> to be excecuted.
>  
> >https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_files

Done! 

> 
> (In reply to comment #2)
> > Hey, 
> > 
> > Thank you for the review :)
> 
> You can say thanks, with reviewing some of mine or other reviews ;)

Drop me an email with your bug numbers and I'll thank you ;)

> 
> > 
> > (In reply to comment #1)
> > > Hmm, do you want to build for python3 or not?
> > > It looks like you started and that's it (haven't tried it either, yet).
> > > 
> > 
> > removed the py3 support, will find out from upstream if this will work for py3
> > or not and later do it.
> > 
> > > * file-in-usr-marked-as-conffile:
> > >   The schemas are in /etc/gconf/schemas/, if you put this schemas also there,
> > > this will be gone
> > 
> > The setup.py installs it in /usr/share/gconf, how do i move it to this correct
> > location? That's what I'm not clear on. 
> 
> with mv. It would be the best, if you ping upstream. This looks like a big
> packaging error from them...
> 
>  49 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/gconf
>  50 mv $RPM_BUILD_ROOT%{_datadir}/gconf $RPM_BUILD_ROOT%{_sysconfdir}
> worked here.
> 

done, pinged upstream too.

> > 
> > > * dangerous-command-in-* rm
> > >   %gconf_schema_prepare contains rm as a command. I don't know if this is sane,
> > > but this seems like a false positive
> > 
> > I've taken the macro from here:
> > 
> > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf
> 
> I never used this macro before, but it needs to be:
> %gconf_schema_prepare %{name} (etc..)
> 

I think I've used the macro correctly. 

> 
> After that you'll have:
> $ rpmlint ./nautilus-pastebin-0.4.1-2.fc13.src.rpm
> noarch/nautilus-pastebin-0.4.1-2.fc13.noarch.rpm 
> nautilus-pastebin.noarch: W: dangerous-command-in-%pre rm
> nautilus-pastebin.noarch: W: dangerous-command-in-%post rm
> 2 packages and 0 specfiles checked; 1 errors, 2 warnings.
> 
> 
> I'll do a review, when you did all changes.    

Done all of them 

regards,
Ankur


rpmlint nautilus-pastebin.spec ../SRPMS/nautilus-pastebin-0.4.1-3.fc12.src.rpm
/var/lib/mock/fedora-rawhide-i386/result/*.rpm
nautilus-pastebin.noarch: W: percent-in-%pre
nautilus-pastebin.noarch: W: percent-in-%post
nautilus-pastebin.noarch: W: percent-in-%preun
3 packages and 1 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.