[Bug 501101] Review Request: emacs-color-theme - elisp mode to customize emacs look and feel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501101

--- Comment #12 from Jonathan Underwood <jonathan.underwood at gmail.com> 2010-04-17 16:06:27 EDT ---
Arun, great to see you're picking the package up, and that you've tackled all
the points in the review.

A few small things:

1/ For F-13 onwards, the %clean section is unnecessary: 
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

2/ The Buildroot tag isn't needed, and you don't need to do rm -rf %{buildroot}
in %install:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

3/ The patches still need a spec file comment regarding their upstream status:
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

Also - should this package not have a startup file (in %{_emacs_sitestartdir})
?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.