[Bug 583141] Review Request: nautilus-pastebin - Nautilus extension to send files to a pastebin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583141

--- Comment #5 from Thomas Spura <tomspur at fedoraproject.org> 2010-04-17 17:04:39 EDT ---
Review:

Good:
- name ok
- group ok
- arch ok
- BR ok
- rpmlint ignorable:
$ rpmlint ./nautilus-pastebin-0.4.1-3.fc13.src.rpm
noarch/nautilus-pastebin-0.4.1-3.fc13.noarch.rpm 
nautilus-pastebin.noarch: W: dangerous-command-in-%pre rm
nautilus-pastebin.noarch: W: dangerous-command-in-%post rm
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
- source match upstream: ad10c5ce66a81bb2b17be31c2e07d4c7
- %install ok
- correctly installing of locales
- %doc ok


Needswork/couldwork:
- URL: when you put there %{version} in too, you don't need to change it all
the time.
- what does your sed in %prep do?
  There is no line 'X-Ubuntu-Gettext-Domain=nautilus-pastebin' or am I wrong?
- RPM_OPT_FLAGS are now obsolete, with the BuildArch: noarch
- license wrong: It's GPLv2+ and not GPLv2
- description:
  last line has as a first character a space and misses a dot at the end
- could you please be a bit more explicit in %files?
with:
%{python_sitelib}/pastebin
%{python_sitelib}/nautilus_pastebin-*-py?.?.egg-info
you know when the egg fails to build

(In reply to comment #4)
> > I never used this macro before, but it needs to be:
> > %gconf_schema_prepare %{name} (etc..)
> > 
> 
> I think I've used the macro correctly. 

I don't know that macro so I ran:
$ rpm --eval %gconf_schema_prepare

if [ "$1" -gt 1 ] ; then 
    rm -rf /var/lib/rpm-state/gconf/* 
    for schema in  ; do 
        if test -f /etc/gconf/schemas/"$schema".schemas ; then 
            cp -p /etc/gconf/schemas/"$schema".schemas
/var/lib/rpm-state/gconf/ || : 
        fi 
    done 
fi 

Means it will copy a schemas file around but does not do something with the
argument you provide (whyever).

On http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf is as
example:
%gconf_schema_prepare foobar

So I guess they want to have:
%gconf_schema_prepare nautilus-pastebin

Or why do you think, your usage is right?


##############################################################################

Current BLOCKER:
- license
- unsure about the macro

  -> rest is SHOULD

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.