[Bug 537366] Review Request: cgal-python - Python bindings for the CGAL library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537366

--- Comment #14 from Chen Lei <supercyper at 163.com> 2010-04-18 08:00:03 EDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > %{!?with_rhel:%{python_sitearch}/*.egg-info}
> > Shoule be changed to :%{python_sitearch}/*.egg-info
> > See 
> > https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Eggs_for_non-setuptools_packages
> I see. There is a way of generating the egg-info for rhel, by using setuptools:
> ----------------------------------------
> %build
> CFLAGS="$RPM_OPT_FLAGS" %{__python} -c 'import setuptools;
> execfile("setup.py")' build
> %install
> rm -rf $RPM_BUILD_ROOT
> %{__python} -c 'import setuptools; execfile("setup.py")' install --skip-build
> --root $RPM_BUILD_ROOT
> ----------------------------------------
> Although I run cgal-python in rhel5, one has to build CGAL first, and
> I am not intending to take both packages to EPEL (I think CGAL is not part of
> EPEL yet).
> Therefore, I think that the use of setuptools for Fedora is unnecessary.
> But I can use it if you think it is better this way. 
> > 

You should follow the item - "Providing Eggs for non-setuptools packages" to
provide egg for rhel or simply remove %bcond_with rhel and %with_rhel macros.
If you like, you can maintain CGAL for epel by "Package Change CVS Request"
without package review.

> > %{!?python_sitearch:%global python_sitearch %(%{__python} -c "from
> > distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
> > ->
> > %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
> > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
> > distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> > %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
> > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
> > %endif    
> This part I did not understand. Why the test? I do not even use python_sitelib.    

See https://fedoraproject.org/wiki/Packaging:Python#Macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.