[Bug 551587] Review Request: java-gnome - Java GNOME bindings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551587

--- Comment #16 from Alexander Boström <abo at root.snowtree.se> 2010-04-18 14:46:03 EDT ---
(In reply to comment #14)
> Ok, if upstream are not worried about it, then I'm not worried about it. :-)
> 
> As for a more formal review, the package in general is very good. Rpmlint is
> clean and the package works (I tried the libnotify example). Thanks for noting
> in the SPEC why parallel make is not used and including a bugzilla link for the
> patch.

Thanks!

> The only *must* guideline that is not followed is this one:
> 
> * On the Java guidelines page, it states that if the project name (java-gnome)
> and the common jar name (gtk) differ, then symlinks must be provided to provide
> jars with both names.
> http://fedoraproject.org/wiki/Packaging:Java#Jar_file_naming

Yeah, earlier revisions of the package did have that symlink, but I removed it
because I thought it was reasonable to assume that that section is meant to
apply to the native JARs that go in /usr/share/java, not to JNI JARs which have
their own section in the guidelines. Now I find I can't really argue
convincingly for that interpretation so I'll put the symlink back.

A while back I requested the packaging committee to consider these updated
guidelines:
http://fedoraproject.org/wiki/User:Abo/JavaPackagingDraftUpdate
Hopefully those will eventually clarify matters.

> * The javadoc sub-package could (should?) be noarch.

Good call. I added this to the package and to my draft guidelines.

> * It's usual to include an unversioned symlink to the Javadocs so that
> bookmarks continue to work after updates, etc.    

Sounds like a good idea. Either that or just an unversioned directory. Fixed
too.

(In reply to comment #15)
> I am able to sponsor you now, BTW, so removing FE-NEEDSPONSOR. :-)

Awesome!


Spec URL:
http://www.root.snowtree.se/abo/fedora/reviews/java-gnome/java-gnome.spec
SRPM URL:
http://www.root.snowtree.se/abo/fedora/reviews/java-gnome/java-gnome-4.0.15-3.fc13.src.rpm

rpmlint:
4 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.