[Bug 226324] Merge Review: psutils

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 19 18:39:52 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226324

--- Comment #11 from Tom "spot" Callaway <tcallawa at redhat.com> 2010-04-19 14:39:49 EDT ---
Daniel, it would be better if your script renamed the tarball to be something
like: psutils-p17-clean.tar.gz

As it is, your Source line implies that it is using the upstream tarball, which
is not correct. I would change it like this:

# We cannot use the upstream tarball because it contains non-free files.
# To generate a clean tarball, run the psutils-remove-copyrighted-files script.
# Source: ftp://ftp.knackered.org/pub/psutils/psutils-p17.tar.gz
Source0: psutils-p17-clean.tar.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the package-review mailing list