Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581334
Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
Flag| |fedora-review?
--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-04-20 14:19:38 EDT ---
Initial comments
* License
- ./doc_DE/dina4.sty does not allow any modification.
This is not allowed on Fedora and this file must be removed
from the source tarball. Please follow:
https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code
* BuildRoot
- BuildRoot is no longer needed on Fedora (although rpmlint may complain
without this)
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
* BR
- For tex related packages, it is recommended to use virtual Provides
names for Requires/BuildRequires instead of using rpms' names directly,
like: "BR: tex(latex)".
! using iconv
- It is better that the lines using iconv should be moved to %prep,
as with it rpmbuild -bi --short-circuit won't break.
* %lang
- For DE related documents, it is preferable that they are marked
as "%lang(de) %doc".
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.