[Bug 578290] Review Request: mj - Mah-Jong program with network option

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 20 20:58:48 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578290

Göran Uddeborg <goeran at uddeborg.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NOTABUG

--- Comment #15 from Göran Uddeborg <goeran at uddeborg.se> 2010-04-20 16:58:43 EDT ---
Thanks for your comments.  I'll make an updated version without the non-GPL
tiles in a couple of days.  In the mean time, a few short comments.

> The Swedish description and summary matches the American
> English ones.

Nice with a reviewer able to verify that! :-)  Would you like to have a Danish
version included too?

> ... one can see that
> things like "#FFFFF0" have changed to things like "ivory"
> many places in the tiles-kdegames. I assume that is a
> consequence of some change in kgegames ...

It could also be a packager being bad in keeping the change log up to date. 
:-)

I'll add a note.

>  %_bindir/*
>  %_mandir/man1/*
> I suppose those lines say that mj owns everything in bin and man1.

Yes, that's correct, it does.  I don't quite understand what you mean the issue
is though.  Do you find it more pretty to explicitly list the three files in
each directory?  I don't have any strong opinion, I could do either way.  Or do
you mean something else?  How should I understand your comment?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list