[Bug 583236] Review Request: vlc - The cross-platform open-source multimedia framework, player and server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583236

--- Comment #10 from Rex Dieter <rdieter at math.unl.edu> 2010-04-21 11:13:35 EDT ---

1.  MUST : fix rpath issues

naming: ok

license: ok

macros: ok

scriptlets: ok (though the icon scriptlets could be updated to use the newer,
optimized version currently in the packaging guidelines)

static libs: none, ok

libtool archives: none, ok

-devel: properly includes headers, and lib*.so symlinks

2.  SHOULD adjust current dep
Requires: qt-x11%{_isa} >= 1:4.5.2
to 
Requires: qt4%{?_isa} >= %{_qt4_version}

3.  SHOULD include the kde4 solid/action items, instead of omitting them.  I'd
recommend dropping
BuildRequires: kdelibs4-devel
and use instead
BuildRequires: kde-filesystem
Requires: kde-filesystem
with configure option:
--with-kde-solid=%{_kde4_appsdir}/solid/actions

I will mention that I *was* going to suggest some more package splits for
shlibs and codecs, mainly for multilib reasons, but the more I think about it,
the current way does make sense.

4. SHOULD clarify why libpulse_plugin.so is in vlc, and not vlc-core


that's all I have so far, will do a final analysis, when we have a new
submission that addressed these items as well as using a stripped tarball per
comment #7.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.