[Bug 580422] Review Request: libdesktop-agnostic - Provides an extensible configuration API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580422

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #12 from Rex Dieter <rdieter at math.unl.edu> 2010-04-21 12:06:29 EDT ---

I like the simplification of the packaging and subpkgs.

wrt item 6, rpmlint notes now,
libdesktop-agnostic.x86_64: W: conffile-without-noreplace-flag
/etc/xdg/libdesktop-agnostic/desktop-agnostic.ini

so maybe better to use
%config(noreplace)
so that end-user modifications don't get lost on upgrades (unless there's good
reason to not preserve them).


nitty gritty,

naming: ok

macros: ok

licensing: ok

sources: ok
$ md5sum *.gz
67141440b7fa77e2d704e7368c067212  libdesktop-agnostic-0.3.90.tar.gz

dir ownership: ok (well, looks like ownership of
%{_libdir}/desktop-agnostic/modules , got lost, re-add that to the main pkg
please)

static libs: ok

libtool archives: ok


APPROVED.  (I'll trust you to address the dir ownership and %config items above
prior to releasing anything).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.