[Bug 581334] Review Request: asl - Macro Assembler AS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581334

--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-04-21 13:59:22 EDT ---
Well,

(In reply to comment #5)
> * License
> The file doesn't appear to be used for anything.  I've reported the issue
> upstream, and for now I have added an rm command in the %prep section.

- As I said in the comment 4, ./doc_DE/dina4.sty must be removed
  from the source tarball itself
  ( i.e. you have to once unpack the source tarball, remove this
    file and repackage the tarball for Fedora. It is better that
    repackaged tarball should be renamed like
    "asl-current-XXXX-clean.tar.bz2 )
  Once again please refer to
 
https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code

? By the way, while srpm release number contains "bld77", the
  source tarball says "bld75" is used.

> * BuildRoot
> I'd like to keep this for now, as I may also submit this for EPEL5.
- Okay.

> ! using iconv
> I can't do it in %prep, as the file is generated.  I'd rather do it in %build,
> but unfortunately the upstream build system generates the doc files in "make
> install", so without doing significant changes to the makefiles, it needs to
> stay in %install.  If you think this is a serious problem, I'll talk with
> upstream.
- Okay.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.