[Bug 576431] Package Review: skipfish - Web application security scanner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576431

Tomas Mraz <tmraz at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(rebus at seznam.cz)

--- Comment #25 from Tomas Mraz <tmraz at redhat.com> 2010-04-22 04:13:58 EDT ---
Sorry but I just consulted this with Jakub Jelinek and this is clearly bug in
the source code of skipfish. The malloc_usable_size() does not allow you to
memset over the end of the length passed to malloc(). There might be very well
some internal data of the allocator. This call just tells you that if you
realloc the allocated memory it will not have to move the block if the newly
requested size is up to the malloc_usable_size() length.

So please
1. report this to the upstream.
2. patch the memset calls so they clear just the allocated memory.
3. change the spec so it properly uses the optflags from rpm including the
FORTIFY_SOURCE=2.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.