[Bug 476056] Review Request: gnustep-back - The GNUstep backend library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476056

Michel Alexandre Salim <michael.silvanus at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Michel Alexandre Salim <michael.silvanus at gmail.com> 2010-04-22 18:08:10 EDT ---
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2132999
rpmlint (SRPM):
gnustep-back.src: W: spelling-error Summary(en_US) backend -> backed, back end,
back-end
gnustep-back.src: W: spelling-error %description -l en_US backend -> backed,
back end, back-end
gnustep-back.src: W: spelling-error %description -l en_US gui -> GUI, goo, gun
gnustep-back.src: W: spelling-error %description -l en_US backends -> back
ends, back-ends, backhands
gnustep-back.src: W: invalid-url Source0:
ftp://ftp.gnustep.org/pub/gnustep/core/gnustep-back-0.16.0.tar.gz <urlopen
error ftp error: timed out>
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

rpmlint (RPMs):
gnustep-back.x86_64: W: spelling-error Summary(en_US) backend -> backed, back
end, back-end
gnustep-back.x86_64: W: spelling-error %description -l en_US backend -> backed,
back end, back-end
gnustep-back.x86_64: W: spelling-error %description -l en_US gui -> GUI, goo,
gun
gnustep-back.x86_64: W: spelling-error %description -l en_US backends -> back
ends, back-ends, backhands
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

=========================================================
REVIEW

Component Status Remarks
rpmlint NEEDFIX See spec language
Package & spec names OK 
Fit for inclusion OK 
Code or content OK 
License acceptable OK 
License accurate NEEDFIX Old files (L)GPLv2+, some new files (L)GPLv3+. Change
to LGPLv3+ and GPLv3+ and comment that only tools are GPLv3+ ?
License included OK 
Spec language NEEDFIX I suggest switching to back-end(s) and GUI
Source matches OK MD5: 31a16abe7c19914c6fe1300881f6c6ab
Compiles OK 
Complete BRs OK 
Locale N/A 
ldconfig N/A 
no bundled libs OK 
Dir ownership NEEDFIX /usr/share/GNUstep/Documentation/Developer has no owner.
Suggest adding to gnustep-filesystem
No dup files NEEDFIX ANNOUNCE, NEWS, README should be removed from
/usr/share/GNUstep/... -- INSTALL too as it's irrelevant to our users
File perms OK 
UTF-8 files OK 
%clean OK 
rm on %install OK 
Consistent macros OK 
Large docs OK 
%doc unessential OK 
Headers in -devel N/A 
*.so.* -> *.so in -devel N/A 
Static in -static N/A 
-devel Req main N/A 
No .la N/A 
Desktop files N/A

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.